dcapwell commented on code in PR #3785:
URL: https://github.com/apache/cassandra/pull/3785#discussion_r1927701864
##########
test/harry/main/org/apache/cassandra/harry/model/PartitionState.java:
##########
@@ -223,7 +232,7 @@ private RowState updateRowState(RowState currentState,
IntFunction<Bijections.Bi
assert lts >= currentState.lts[i] :
String.format("Out-of-order LTS: %d. Max seen: %s", lts, currentState.lts[i]);
// sanity check; we're iterating in lts order
- if (currentState.lts[i] == lts)
+ if (lts != MagicConstants.NO_TIMESTAMP && currentState.lts[i]
== lts)
Review Comment:
Sorry, bad sentence.
the ast tests in this PR do not track timestamps, they rely on server to
calculate them. The existing logic expects harry to own the timestamps and
update the `lts`, so i need a way to opt-out of this behavior; hence this
change.
When the caller defines the `lts` as `NO_TIMESTAMP` that tells harry to just
accept the write and override, rather than try to deal with timestamp conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
