dcapwell commented on code in PR #3785: URL: https://github.com/apache/cassandra/pull/3785#discussion_r1927720547
########## test/distributed/org/apache/cassandra/distributed/test/cql3/MultiNodeTableWalkTest.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.distributed.test.cql3; + +import java.io.IOException; +import javax.annotation.Nullable; + +import accord.utils.Property; +import org.apache.cassandra.distributed.Cluster; +import org.apache.cassandra.service.consensus.TransactionalMode; + +public class MultiNodeTableWalkTest extends SingleNodeTableWalkTest +{ + + public MultiNodeTableWalkTest() + { + } + + protected MultiNodeTableWalkTest(@Nullable TransactionalMode transactionalMode) + { + super(transactionalMode); + } + + @Override + protected void preCheck(Property.StatefulBuilder builder) + { + // if a failing seed is detected, populate here + // Example: builder.withSeed(42L); + // To show string/blobs + SHOW_REAL_VALUES = true; + builder.withSeed(159634037219554562L); + } + + @Override + protected Cluster createCluster() throws IOException + { + return createCluster(3, c -> { + c.set("range_request_timeout", "180s") Review Comment: > Should these be set this high because queries are slow or to allow debugging? these were copy/pasted from the harry sai tests... its mostly to avoid timeouts as those will cause the test to be unstable. If a write times out and can't be retried, you must abandon the test because harry doesn't support unknown write state (paxos/accord simulator test model does, just not harry). Right now there isn't retry logic in any of the read/write paths... when dealing with single node it hasn't been too much of an issue... if i add that i would have to do what we did in the accord tests, and check to see if its safe to retry the query, and if not you *must* abandon the test... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
