smiklosovic commented on code in PR #3908:
URL: https://github.com/apache/cassandra/pull/3908#discussion_r1966743811
##########
src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java:
##########
@@ -308,12 +308,15 @@ private static String resolvePassword(String
keystoreFilePath, String password,
return password;
if (StringUtils.isEmpty(passwordFilePath))
- return null;
+ return password;
Review Comment:
@maulin-vasavada strange change, `password` here will be `null` anyway
because if it was not then we would return in the `if` above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
