smiklosovic commented on code in PR #3908:
URL: https://github.com/apache/cassandra/pull/3908#discussion_r1966744304
##########
src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java:
##########
@@ -308,12 +308,15 @@ private static String resolvePassword(String
keystoreFilePath, String password,
return password;
if (StringUtils.isEmpty(passwordFilePath))
- return null;
+ return password;
Review Comment:
Aha I see what you did here. OK. Because `isEmpty(password)` will return
false only if it is not null AND String does not have length of 0.
But here you covered the case of returning password of empty string instead
of null ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
