smiklosovic commented on code in PR #3908:
URL: https://github.com/apache/cassandra/pull/3908#discussion_r1973526592


##########
src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java:
##########
@@ -294,5 +301,38 @@ protected boolean passwordMatchesIfPresent(String 
keyPassword)
         {
             return StringUtils.isEmpty(password) || 
keyPassword.equals(password);
         }
+
+        private static String resolvePassword(String keystoreFilePath, String 
password, String passwordFilePath)
+        {
+            if (password != null)
+                return password;
+
+            if (StringUtils.isEmpty(passwordFilePath))
+                return password;

Review Comment:
   @maulin-vasavada  that is what I was mentioning here 
   
   
https://issues.apache.org/jira/browse/CASSANDRA-13428?focusedCommentId=17929657&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17929657



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to