dcapwell commented on code in PR #3976:
URL: https://github.com/apache/cassandra/pull/3976#discussion_r1995919577
##########
src/java/org/apache/cassandra/service/accord/AccordJournalValueSerializers.java:
##########
@@ -30,21 +30,27 @@
import accord.primitives.TxnId;
import org.apache.cassandra.io.util.DataInputPlus;
import org.apache.cassandra.io.util.DataOutputPlus;
+import org.apache.cassandra.net.MessagingService;
import org.apache.cassandra.service.accord.journal.AccordTopologyUpdate;
import org.apache.cassandra.service.accord.serializers.CommandStoreSerializers;
import org.apache.cassandra.service.accord.serializers.Version;
-import static accord.api.Journal.Load.ALL;
import static accord.local.CommandStores.RangesForEpoch;
// TODO (required): test with large collection values, and perhaps split out
some fields if they have a tendency to grow larger
// TODO (required): alert on metadata size
// TODO (required): versioning
public class AccordJournalValueSerializers
{
- public interface FlyweightSerializer<ENTRY, IMAGE>
+ private static final int messagingVersion = MessagingService.VERSION_40;
Review Comment:
its private and don't see anything in this class use it, so its dead code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
