dcapwell commented on code in PR #3976: URL: https://github.com/apache/cassandra/pull/3976#discussion_r1995905867
########## src/java/org/apache/cassandra/journal/Params.java: ########## @@ -58,5 +60,5 @@ enum FailurePolicy { STOP, STOP_JOURNAL, IGNORE, DIE } /** * @return user provided version to use for key and value serialization */ - int userVersion(); + Version userVersion(); Review Comment: this is the `journal` package, but you switch to the accord version? How does this impact CEP-45 (mutation tracking)? They won't be using the accord version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org