dcapwell commented on code in PR #3976:
URL: https://github.com/apache/cassandra/pull/3976#discussion_r1995939099


##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -1149,7 +1149,7 @@ public void close()
                            .collect(Collectors.toList());
         try
         {
-            FBUtilities.waitOnFutures(futures, 1L, TimeUnit.MINUTES);
+            FBUtilities.waitOnFutures(futures, instances.size(), 
TimeUnit.MINUTES);

Review Comment:
   what examples are you referring to?  a cluster with 12 nodes having 12 
minutes to shutdown feels very excessive.  Even 3 node cluster having 3m takes 
away time from other tests to run in CI



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to