tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1997853263
##########
bin/sstableloader:
##########
@@ -32,18 +35,6 @@ elif [ -r "$CASSANDRA_INCLUDE" ]; then
. "$CASSANDRA_INCLUDE"
fi
-if [ -z "$CLASSPATH" ]; then
- echo "You must set the CLASSPATH var" >&2
- exit 1
-fi
-
-if [ "x$MAX_HEAP_SIZE" = "x" ]; then
- MAX_HEAP_SIZE="256M"
-fi
-
-"$JAVA" $JAVA_AGENT -ea -cp "$CLASSPATH" $JVM_OPTS -Xmx$MAX_HEAP_SIZE \
- -Dcassandra.storagedir="$cassandra_storagedir" \
- -Dlogback.configurationFile=logback-tools.xml \
- org.apache.cassandra.tools.BulkLoader "$@"
+"$CASSANDRA_HOME/tools/bin/sstableloader" "$@"
Review Comment:
I tried building both the debian and redhat package and noticed that
`sstableloader`, `cassandra-stress` and `fqltool` were all present in the base
package, not tools. Given that is the case, I think its best to continue
packaging things this way, and to update the builders to copy the sstableloader
jar and the correct binary with it. Will push a change that does this shortly.
Another thing I noticed was that these jars are always present on the
classpath, even for cassandra server. When I implement
[CASSANDRA-20329](https://issues.apache.org/jira/browse/CASSANDRA-20329) I'll
make sure that is no longer the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
