smiklosovic commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1998553735
##########
bin/sstableloader:
##########
@@ -32,18 +35,18 @@ elif [ -r "$CASSANDRA_INCLUDE" ]; then
. "$CASSANDRA_INCLUDE"
fi
-if [ -z "$CLASSPATH" ]; then
- echo "You must set the CLASSPATH var" >&2
- exit 1
-fi
+SSTABLELOADER_PATH="$CASSANDRA_HOME/tools/bin/sstableloader"
-if [ "x$MAX_HEAP_SIZE" = "x" ]; then
- MAX_HEAP_SIZE="256M"
+if [ ! -f "$SSTABLELOADER_PATH" ]; then
+ echo "Note: sstableloader has moved to the tools directory. \
+Detected that $SSTABLELOADER_PATH does not exist, this is likely a packaging \
Review Comment:
I don't get `this is likely a packaging issue as this script should not be
installed.`
Imho should be `Note: sstableloader has moved to the tools directory. Please
install cassandra-tools package and try again.`
This script should be still installed. It is just it will point to a new
executable. It is just a delegate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
