smiklosovic commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1998551372
##########
bin/sstableloader:
##########
@@ -32,18 +35,18 @@ elif [ -r "$CASSANDRA_INCLUDE" ]; then
. "$CASSANDRA_INCLUDE"
fi
-if [ -z "$CLASSPATH" ]; then
- echo "You must set the CLASSPATH var" >&2
- exit 1
-fi
+SSTABLELOADER_PATH="$CASSANDRA_HOME/tools/bin/sstableloader"
-if [ "x$MAX_HEAP_SIZE" = "x" ]; then
- MAX_HEAP_SIZE="256M"
+if [ ! -f "$SSTABLELOADER_PATH" ]; then
+ echo "Note: sstableloader has moved to the tools directory. \
+Detected that $SSTABLELOADER_PATH does not exist, this is likely a packaging \
+issue as this script should not be installed." >&2
+ exit 1
+else
+ echo "Warning: sstableloader has been moved to the tools directory. \
Review Comment:
@tolbertam I am not sure we want to do this. The logic should be "if the
script in tools does not exist, tell user that it moved to tools and they
should install that package, otherwise run it".
In other words, there is no reason to emit a warning telling a user that
script moved and then execute that script. Why should a user care it moved if
it works? I would just remove that "else" branch completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
