smiklosovic commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r1998583185
##########
bin/sstableloader:
##########
@@ -32,18 +35,18 @@ elif [ -r "$CASSANDRA_INCLUDE" ]; then
. "$CASSANDRA_INCLUDE"
fi
-if [ -z "$CLASSPATH" ]; then
- echo "You must set the CLASSPATH var" >&2
- exit 1
-fi
+SSTABLELOADER_PATH="$CASSANDRA_HOME/tools/bin/sstableloader"
-if [ "x$MAX_HEAP_SIZE" = "x" ]; then
- MAX_HEAP_SIZE="256M"
+if [ ! -f "$SSTABLELOADER_PATH" ]; then
+ echo "Note: sstableloader has moved to the tools directory. \
+Detected that $SSTABLELOADER_PATH does not exist, this is likely a packaging \
Review Comment:
hmmm thinking about it more, I see what we are doing here. This script is
still part of tarball, it is just not "installed" as part of deb / rpm. When I
look closely, I see this was installed to `/usr/bin/sstableloader` and
`tools/bin/sstableloader` can not be installed there as well upon installing
tools package because it would replace what was already in
`/usr/bin/sstableloader`. Huh.
But still. I don't think this is a _packaging issue_. Because e.g. a
developer might still execute this script as he develops. I would just say that
it moved too tools dir when not present. That's it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
