smiklosovic commented on code in PR #3899: URL: https://github.com/apache/cassandra/pull/3899#discussion_r1998601162
########## bin/sstableloader: ########## @@ -32,18 +35,6 @@ elif [ -r "$CASSANDRA_INCLUDE" ]; then . "$CASSANDRA_INCLUDE" fi -if [ -z "$CLASSPATH" ]; then - echo "You must set the CLASSPATH var" >&2 - exit 1 -fi - -if [ "x$MAX_HEAP_SIZE" = "x" ]; then - MAX_HEAP_SIZE="256M" -fi - -"$JAVA" $JAVA_AGENT -ea -cp "$CLASSPATH" $JVM_OPTS -Xmx$MAX_HEAP_SIZE \ - -Dcassandra.storagedir="$cassandra_storagedir" \ - -Dlogback.configurationFile=logback-tools.xml \ - org.apache.cassandra.tools.BulkLoader "$@" +"$CASSANDRA_HOME/tools/bin/sstableloader" "$@" Review Comment: @tolbertam I see. So the plan is to keep packaging sstableloader as is, it would be just a different class path etc. Right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org