maedhroz commented on code in PR #3987: URL: https://github.com/apache/cassandra/pull/3987#discussion_r2000148685
########## src/java/org/apache/cassandra/db/rows/BTreeRow.java: ########## @@ -399,9 +399,9 @@ public boolean hasComplex() public boolean hasComplexDeletion() { - long result = accumulate((cd, v) -> ((ComplexColumnData) cd).complexDeletion().isLive() ? 0 : Cell.MAX_DELETION_TIME, + long result = accumulate((cd, v) -> ((ComplexColumnData) cd).complexDeletion().isLive() ? 0 : Long.MAX_VALUE, COLUMN_COMPARATOR, isStatic() ? FIRST_COMPLEX_STATIC : FIRST_COMPLEX_REGULAR, 0L); - return result == Cell.MAX_DELETION_TIME; + return result == Long.MAX_VALUE; Review Comment: I simply reverted here rather than trying to do something less brittle around the stop value. Open to doing that if we think it really helps... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org