aratno commented on code in PR #3987:
URL: https://github.com/apache/cassandra/pull/3987#discussion_r2001750242
##########
src/java/org/apache/cassandra/utils/btree/BTree.java:
##########
@@ -1823,7 +1824,7 @@ private static <V> int find(Object[] btree, V from,
Comparator<V> comparator)
private static boolean isStopSentinel(long v)
{
- return v == Long.MAX_VALUE;
+ return v == STOP_SENTINEL_VALUE;
Review Comment:
Could you update docstring on `BTree#accumulate`? Also looks like we stopped
using the sentinel Long.MIN_VALUE here a while ago, seems like a mistake in the
comment.
Not something that should be addressed in this patch, but feels like we
should have a separate AbortableLongAccumulator that signals early termination
out of band to make this even safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
