maedhroz commented on code in PR #3987: URL: https://github.com/apache/cassandra/pull/3987#discussion_r2001692799
########## src/java/org/apache/cassandra/utils/ByteBufferUtil.java: ########## @@ -544,6 +548,17 @@ else if (obj instanceof byte[]) return ByteBuffer.wrap((byte[]) obj); else if (obj instanceof ByteBuffer) return (ByteBuffer) obj; + else if (obj instanceof Set) + { + Set<?> set = (Set<?>) obj; + // convert subtypes to BB + Set<ByteBuffer> bbs = new LinkedHashSet<>(); Review Comment: I wanted to make this match what was in trunk...although I agree in principle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org