Re: [PR] CASSANDRA-20328: Migrate sstableloader code to its own tools directory and artifact [cassandra]

[via GitHub]

tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r2000226951


##########
build.xml:
##########
@@ -1986,7 +2078,7 @@
     </path>
     <pathconvert property="eclipse-libs-list" 
refid="eclipse-project-libs-path" pathsep="${line.separator}">
         <mapper>
-            <regexpmapper from="^(.*)$$" to='&lt;classpathentry kind="lib" 
path="\1\" \/&gt;'/>
+            <regexpmapper from="^(.*)$$" to='  &lt;classpathentry kind="lib" 
path="\1" /&gt;'/>

Review Comment:
   This was previously generating invalid xml in the .classpath file:
   
   ```
   <classpathentry kind="lib" 
path="/home/tolbertam/Documents/Projects/cassandra/lib/ST4-4.0.8.jar\" \/>
   ```
   
   In particular the `\/>` part is invalid but I expect `...jar\"` probably 
would throw things off too.  Also added two whitespaces to the beginning to 
make the spacing look right (not reqiuired, just prettier). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org