tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r2000233372
##########
build.xml:
##########
@@ -2008,8 +2100,10 @@
<classpathentry kind="src" output="${test.classes}" path="test/resources" />
<classpathentry kind="src" path="tools/stress/src"/>
<classpathentry kind="src" path="tools/fqltool/src"/>
+ <classpathentry kind="src" path="tools/sstableloader/src"/>
Review Comment:
This seems to work as I can run `SSTableLoaderTest` and all the tests pass,
but I had to make eclipse work again as it looks like it's currently broken for
a number of reasons (see other comments).
If you think these changes are out of scope let me know and I can do them as
a separate jira/PR.
Note that after doing this there were still a few things i needed to do:
1. Add `-DallowAttachSelf=true` to the VM run arguments for any run
configuration.
2. Update `SortedTableWriter.AbstractIndexWriter` to be public as otherwise
I get this error:
```
Caused by: java.lang.Error: Unresolved compilation problem:
The type SortedTableWriter.AbstractIndexWriter is not visible
at
org.apache.cassandra.io.sstable.format.big.BigTableWriter$IndexWriter.<init>(BigTableWriter.java:237)
at
org.apache.cassandra.io.sstable.format.big.BigTableWriter$Builder.openIndexWriter(BigTableWriter.java:405)
at
org.apache.cassandra.io.sstable.format.big.BigTableWriter$Builder.openIndexWriter(BigTableWriter.java:1)
```
Change made:
```diff
diff --git
a/src/java/org/apache/cassandra/io/sstable/format/SortedTableWriter.java
b/src/java/org/apache/cassandra/io/sstable/format/SortedTableWriter.java
index 4fca9ca181..67ae1c7402 100644
--- a/src/java/org/apache/cassandra/io/sstable/format/SortedTableWriter.java
+++ b/src/java/org/apache/cassandra/io/sstable/format/SortedTableWriter.java
@@ -427,7 +427,7 @@ public abstract class SortedTableWriter<P extends
SortedTablePartitionWriter, I
}
}
- protected static abstract class AbstractIndexWriter extends
AbstractTransactional implements Transactional
+ public static abstract class AbstractIndexWriter extends
AbstractTransactional implements Transactional
{
protected final Descriptor descriptor;
protected final TableMetadataRef metadata;
```
I suspect this isn't actually necessary, I think maybe what is happening is
the code ends up somewhere else on the build path, as I see duplication in the
jars being added, so the same may be happening on the classpath. I'm not sure
how much further I should to take this other than to ensure I can at a base
level get things working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
