tolbertam commented on code in PR #3899:
URL: https://github.com/apache/cassandra/pull/3899#discussion_r2000224360
##########
build.xml:
##########
@@ -2002,18 +2094,26 @@
<classpathentry kind="src" output="${test.classes}" path="test/memory"/>
<classpathentry kind="src" output="${test.classes}" path="test/burn"/>
<classpathentry kind="src" output="${test.classes}" path="test/anttasks"/>
+ <classpathentry kind="src" output="${test.classes}" path="test/harry/main" />
<classpathentry kind="src" output="${test.classes}" path="test/distributed"/>
<classpathentry kind="src" output="${test.classes}"
path="test/simulator/asm"/>
<classpathentry kind="src" output="${test.classes}"
path="test/simulator/main"/>
<classpathentry kind="src" output="${test.classes}" path="test/resources" />
<classpathentry kind="src" path="tools/stress/src"/>
<classpathentry kind="src" path="tools/fqltool/src"/>
+ <classpathentry kind="src" path="tools/sstableloader/src"/>
<classpathentry kind="src" output="build/test/stress-classes"
path="tools/stress/test/unit" />
<classpathentry kind="src" output="build/test/fqltool-classes"
path="tools/fqltool/test/unit" />
- <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+ <classpathentry kind="src" output="build/test/sstableloader-classes"
path="tools/sstableloader/test/unit" />
+ <classpathentry kind="con"
path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
+ <attributes>
+ <attribute name="module" value="true"/>
+ <attribute name="add-exports"
value="java.base/jdk.internal.misc=ALL-UNNAMED:java.base/jdk.internal.ref=ALL-UNNAMED:java.base/jdk.internal.util=ALL-UNNAMED:java.base/sun.nio.ch=ALL-UNNAMED:java.management.rmi/com.sun.jmx.remote.internal.rmi=ALL-UNNAMED:java.rmi/sun.rmi.registry=ALL-UNNAMED:java.rmi/sun.rmi.server=ALL-UNNAMED:java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED:java.sql/java.sql=ALL-UNNAMED"/>
Review Comment:
Just copied these from the definition elsewhere in build.xml. I'm guessing
we could programmatically generate this somehow, but wasn't sure if that was
worth the trouble.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
