maulin-vasavada commented on code in PR #3985:
URL: https://github.com/apache/cassandra/pull/3985#discussion_r2006304491
##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -173,8 +173,10 @@ static class Builder
int storagePort;
int sslStoragePort;
EncryptionOptions clientEncOptions = new EncryptionOptions();
+ EncryptionOptions.Builder clientEncOptionsBuilder = new
EncryptionOptions.Builder(clientEncOptions);
int connectionsPerHost = 1;
EncryptionOptions.ServerEncryptionOptions serverEncOptions = new
EncryptionOptions.ServerEncryptionOptions();
+ EncryptionOptions.ServerEncryptionOptions.Builder
serverEncOptionsBuilder = new
EncryptionOptions.ServerEncryptionOptions.Builder(serverEncOptions);
Review Comment:
Thanks @smiklosovic for pointing it out. It led to a little bigger discovery
:) I realized I had to make little more changes to the `LoaderOptions#Builder`.
I made those changes. However, I am thinking if there is a way to test this
class. Currently there are no tests I can run to validate (otherwise most
likely I could have caught this missing changes). Any suggestions for tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
