maulin-vasavada commented on code in PR #3985:
URL: https://github.com/apache/cassandra/pull/3985#discussion_r2006400894


##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -173,8 +173,10 @@ static class Builder
         int storagePort;
         int sslStoragePort;
         EncryptionOptions clientEncOptions = new EncryptionOptions();
+        EncryptionOptions.Builder clientEncOptionsBuilder = new 
EncryptionOptions.Builder(clientEncOptions);
         int connectionsPerHost = 1;
         EncryptionOptions.ServerEncryptionOptions serverEncOptions = new 
EncryptionOptions.ServerEncryptionOptions();
+        EncryptionOptions.ServerEncryptionOptions.Builder 
serverEncOptionsBuilder = new 
EncryptionOptions.ServerEncryptionOptions.Builder(serverEncOptions);

Review Comment:
   I added more test to validate the encryption options override that can catch 
what my pervious changes missed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to