maulin-vasavada commented on code in PR #3985:
URL: https://github.com/apache/cassandra/pull/3985#discussion_r2029573688
##########
src/java/org/apache/cassandra/net/InboundConnectionSettings.java:
##########
@@ -146,7 +147,7 @@ public InboundConnectionSettings
withLegacySslStoragePortDefaults()
ServerEncryptionOptions encryption = this.encryption;
if (encryption == null)
encryption =
DatabaseDescriptor.getInternodeMessagingEncyptionOptions();
- encryption =
encryption.withOptional(false).withInternodeEncryption(ServerEncryptionOptions.InternodeEncryption.all);
+ encryption = new
Builder(encryption).withOptional(false).withInternodeEncryption(ServerEncryptionOptions.InternodeEncryption.all).build();
Review Comment:
I liked your suggestion @Maxwell-Guo but I realize there are many places
that will need to be changed because I don't feel that we should have
alternative constructors also in the Builder class used by callers if we add
this build method. One way is better than having two ways without much
significant differences. Hence I reverted my commit and marked this as
"unresolved" for you to review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
