dcapwell commented on code in PR #3986:
URL: https://github.com/apache/cassandra/pull/3986#discussion_r2017666699
##########
src/java/org/apache/cassandra/service/accord/AccordExecutorAbstractLockLoop.java:
##########
@@ -266,4 +273,18 @@ protected void runWithoutLock(Interruptible.State state)
throws InterruptedExcep
}
}
}
+
+ @Override
+ public void shutdown()
+ {
+ shutdown = true;
Review Comment:
here is what i see for `AccordExecutorSyncSubmit`
1) `shutdown` is called in random thread during shutdown
2) `notifyWorkExclusive` does `hasWork.signal();`
3) with lock case only checks this lock once we have no work to do, which is
after we access this field
so from a JMM point of view this doesn't look like it actually forces the
visibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
