dcapwell commented on code in PR #3986: URL: https://github.com/apache/cassandra/pull/3986#discussion_r2017667378
########## src/java/org/apache/cassandra/service/accord/AccordExecutorAbstractLockLoop.java: ########## @@ -266,4 +273,18 @@ protected void runWithoutLock(Interruptible.State state) throws InterruptedExcep } } } + + @Override + public void shutdown() + { + shutdown = true; Review Comment: Also, we don't block *new* work once we shutdown, so if the node is very busy this will keep going? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org