belliottsmith commented on code in PR #3986:
URL: https://github.com/apache/cassandra/pull/3986#discussion_r2018174034
##########
src/java/org/apache/cassandra/service/accord/AccordExecutorAbstractLockLoop.java:
##########
@@ -266,4 +273,18 @@ protected void runWithoutLock(Interruptible.State state)
throws InterruptedExcep
}
}
}
+
+ @Override
+ public void shutdown()
+ {
+ shutdown = true;
Review Comment:
Visibility is enforced by other volatile accesses. The writer notifies work
as you correctly surmised (which involves a volatile write), and the readers
are all guarded by volatile reads on the lock they are guarded by (that we
notify of work). The volatile keyword on this field would provide no guarantees
on its own and offers no additional guarantees.
it is true that we don’t reject new work but this executor *should* be
shutdown after networking and we should not really reject any work being
produced by the local machine during shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
