belliottsmith commented on code in PR #3986:
URL: https://github.com/apache/cassandra/pull/3986#discussion_r2022570662
##########
src/java/org/apache/cassandra/service/accord/AccordExecutorAbstractLockLoop.java:
##########
@@ -266,4 +273,18 @@ protected void runWithoutLock(Interruptible.State state)
throws InterruptedExcep
}
}
}
+
+ @Override
+ public void shutdown()
+ {
+ shutdown = true;
+ notifyWorkExclusive();
+ }
+
+ @Override
+ public Object shutdownNow()
+ {
+ shutdown();
+ return null;
Review Comment:
My comment above was mistaken (done from a phone on holiday making
assumptions about code location). This place _does_ implement `Shutdownable`.
Removing this therefore means not implementing `Shutdownable`. The description
for `shutdownNow` in `Shutdownable` makes clear it is up to the implementation
whether `shutdownNow` actually does anything to stop ongoing tasks, and this is
true even for `ExecutorService` (though, the description there is that it is
'best effort', it makes clear there are no guarantees which is broadly
equivalent to implementation defined)
I don't terribly mind not implementing `Shutdownable` though, if you're
strongly of this view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
