dcapwell commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2029448448
##########
accord-core/src/main/java/accord/coordinate/ExecuteSyncPoint.java:
##########
@@ -249,6 +249,6 @@ protected void start()
{
SortedArrayList<Node.Id> contact = tracker.filterAndRecordFaulty();
if (contact == null) tryFailure(new Exhausted(syncPoint.syncId,
syncPoint.route.homeKey(), null));
- else node.send(contact, to -> new WaitUntilApplied(to,
tracker.topologies(), syncPoint.syncId, syncPoint.route,
syncPoint.syncId.epoch()), executor, this);
+ else node.send(contact, to -> new WaitUntilApplied(to,
tracker.topologies(), syncPoint.syncId, syncPoint.route,
tracker.topologies().currentEpoch()), executor, this);
Review Comment:
why this change? `currentEpoch` is the `execute_at` epoch where as
syncId.epoch was txn_id right? this is sync so shouldn't `execute_at ==
txn_id`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
