belliottsmith commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2018129521
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -701,8 +701,8 @@ public void markShardDurable(SafeCommandStore safeStore,
TxnId globalSyncId, Ran
protected void updatedRedundantBefore(SafeCommandStore safeStore, TxnId
syncId, Ranges ranges)
{
TxnId clearWaitingBefore =
redundantBefore.minShardAndLocallyAppliedBefore();
- TxnId clearAnyBefore = durableBefore().min.majorityBefore;
- progressLog.clearBefore(safeStore, clearWaitingBefore, clearAnyBefore);
+ TxnId clearAllBefore = TxnId.min(clearWaitingBefore,
durableBefore().min.majorityBefore);
Review Comment:
It’s clearer to have the caller declare what they actually want rather than
have the callee reinterpret, which can be surprising
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
