belliottsmith commented on code in PR #183:
URL: https://github.com/apache/cassandra-accord/pull/183#discussion_r2018133626
##########
accord-core/src/main/java/accord/impl/CommandChange.java:
##########
@@ -90,18 +91,18 @@ public enum Field
{
PARTICIPANTS, // stored first so we can index it
SAVE_STATUS,
- PARTIAL_DEPS,
Review Comment:
To make the field order consistent throughout this class and also broadly
consistent with the rest of the codebase (except where otherwise necessary for
efficiency, ie participants)
Nothing has been released yet, so this is not a breaking change, which is
why it is important to make this kind of consistency change before that happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
