michaelsembwever commented on code in PR #3899: URL: https://github.com/apache/cassandra/pull/3899#discussion_r2030989522
########## .build/sstableloader-deps-template.xml: ########## Review Comment: i've never settled happy on the naming structure of these new files. i think i'd prefer `.build/sstableloader-deps-maven-pom.xml` as something that was more intuitive. "template" doesn't tell us much (it's not that important to know upfront that this file gets filtered during the build), but immediate feedback that this is our maven pom dependency declarations is valuable. but any rename should apply consistently to all such files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
