k-rus commented on PR #4038: URL: https://github.com/apache/cassandra/pull/4038#issuecomment-2823571197
@smiklosovic @pkolaczk I pushed a commit to separate name length validations from the validation for emptiness and characters. The rational is: - Different names require different length validations and some validations will be more dynamic, e.g., table name in 4.x or index name. - It gives opportunity to separate errors on length and on characters. My understanding is that originally any name should fit 48 character, thus it made sense to have the length validation in the same function as the character validation. However, since the length validation was missed for some names, there can be longer names in existing databases, and thus 48 characters cannot be applied. What do you think about the last implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
