bdeggleston commented on code in PR #4150: URL: https://github.com/apache/cassandra/pull/4150#discussion_r2098940658
########## src/java/org/apache/cassandra/utils/CloseableIterator.java: ########## @@ -24,6 +24,8 @@ public interface CloseableIterator<T> extends Iterator<T>, AutoCloseable { public void close(); + + public default void checkpoint() { } Review Comment: instead of adding this to the `CloseableIterator` interface, why don't you make the anonymous MergeListener in ReplicaFilteringProtection a class that you can manipulate or "checkpoint" from `queryProtectedPartitions`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org