Re: [PR] CASSANDRA-20639 Replica filtering protection can trigger short-read protection too aggressively when the LIMIT is less than the number of results in a partition [cassandra]

[via GitHub]

jasonstack commented on code in PR #4150:
URL: https://github.com/apache/cassandra/pull/4150#discussion_r2105751200


##########
src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java:
##########
@@ -350,16 +375,66 @@ public TableMetadata metadata()
             }
 
             @Override
-            public void close() { }
+            public void close()
+            {
+                if (currentRowIterator != null)
+                    currentRowIterator.close();
+            }
 
             @Override
             public boolean hasNext()
             {
                 // If there are no cached partition builders for this source, 
advance the first phase iterator, which
-                // will force the RFP merge listener to load at least the next 
protected partition.
+                // will force the RFP merge listener to load rows from the 
next protected partition.
                 if (partitions.isEmpty())
                 {
-                    PartitionIterators.consumeNext(merged);
+                    if (consumeEntirePartitions)

Review Comment:
   nvm, `currentRowIterator` is used when `consumeEntirePartitions` is false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org