maedhroz commented on code in PR #4150:
URL: https://github.com/apache/cassandra/pull/4150#discussion_r2102981055
##########
src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java:
##########
@@ -270,6 +277,11 @@ public void
onMergedRangeTombstoneMarkers(RangeTombstoneMarker merged, RangeTomb
@Override
public void close()
+ {
+ }
Review Comment:
I think, as it stands, there's no situation where calling `close()` on the
merge listener would do anything useful, given we're manually checkpointing in
`queryProtectedPartitions()`, which used to close the iterator before this
patch (hence the checkpoint logic being in `close()`). Looking at the [other
comment](https://github.com/apache/cassandra/pull/4150/files#r2085863141) below
about whether we even want to modify the iterator contracts, let's come back to
this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
