dcapwell commented on code in PR #4175:
URL: https://github.com/apache/cassandra/pull/4175#discussion_r2100626536
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -294,6 +296,12 @@ public boolean appliesTo(Row row)
return operator.isSatisfiedBy(column.type, rowValue(row), value);
}
+ @Override
+ public boolean isNull(Row row)
+ {
+ return column.type.isNull(rowValue(row));
Review Comment:
`isNull` has the following semantics
1) for non-meangingless emptyness `null` and `empty` are both `null`
2) for meangingless emptyness `null` and `empty` are both `null`
3) for types that support empty, only `null` is `null`
The main difference between 1/2 is that in 1 `empty` is rejected during
validation, so normally means you passed a tombstone here by mistake (historic
bug on the read path in `RowFilter`). 2 allows `empty` during validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
