dcapwell commented on code in PR #4175:
URL: https://github.com/apache/cassandra/pull/4175#discussion_r2100647228
##########
src/java/org/apache/cassandra/service/accord/txn/TxnReferenceValue.java:
##########
@@ -60,9 +62,10 @@ enum Kind
public static class Constant extends TxnReferenceValue
{
+ @Nullable
private final ByteBuffer value;
- public Constant(ByteBuffer value)
+ public Constant(@Nullable ByteBuffer value)
Review Comment:
should add a test to show this, but the value can be null which leads to NPE
later on, so marked this nullable and made it handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
