dcapwell commented on code in PR #4175:
URL: https://github.com/apache/cassandra/pull/4175#discussion_r2100707808
##########
src/java/org/apache/cassandra/service/accord/AccordResult.java:
##########
@@ -142,6 +143,8 @@ else if (isTxnRequest && coordinationFailed instanceof
TopologyMismatch)
}
else
{
+ logger.error("Unexpected exception", fail);
Review Comment:
I was seeing that logs were clean but exceptions were happening, and found
that this code block was hiding all these exceptions. The error isn't a
`CoordinationFailed` so its not expected, so we should be loud! I found
several unexpected exceptions by adding this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
