dcapwell commented on code in PR #203:
URL: https://github.com/apache/cassandra-accord/pull/203#discussion_r2141132664
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -142,7 +142,7 @@ void onNewEpochTopologyMismatch(TopologyMismatch mismatch)
proposeInvalidate(node, node.uniqueTimestamp(Ballot::fromValues),
txnId, route.homeKey(), (outcome, failure) -> {
if (failure != null)
mismatch.addSuppressed(failure);
- setFailure(mismatch);
+ callback.accept(null, mismatch);
Review Comment:
This patch doesn't remove and intellij is telling me that there are still
callers to `setFailure`, why would you call `setFailure` in one code path and
another directly notify the callback? For example, this no longer updates the
`eventListener` and doesn't set `isDone` (if we trigger the callback are we not
actually done?)
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -142,7 +142,7 @@ void onNewEpochTopologyMismatch(TopologyMismatch mismatch)
proposeInvalidate(node, node.uniqueTimestamp(Ballot::fromValues),
txnId, route.homeKey(), (outcome, failure) -> {
if (failure != null)
mismatch.addSuppressed(failure);
- setFailure(mismatch);
+ callback.accept(null, mismatch);
Review Comment:
This patch doesn't remove `setFailure` and intellij is telling me that there
are still callers to `setFailure`, why would you call `setFailure` in one code
path and another directly notify the callback? For example, this no longer
updates the `eventListener` and doesn't set `isDone` (if we trigger the
callback are we not actually done?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
