belliottsmith commented on code in PR #203:
URL: https://github.com/apache/cassandra-accord/pull/203#discussion_r2141158794
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -142,7 +142,7 @@ void onNewEpochTopologyMismatch(TopologyMismatch mismatch)
proposeInvalidate(node, node.uniqueTimestamp(Ballot::fromValues),
txnId, route.homeKey(), (outcome, failure) -> {
if (failure != null)
mismatch.addSuppressed(failure);
- setFailure(mismatch);
+ callback.accept(null, mismatch);
Review Comment:
> If this change actually matters it implies that it was called after
isDone == true
I think I answered this already unless I'm missing something? Sorry if it
was ambiguous, or if I have misunderstood something additional. To quote: "It
is a callback ... that occurs _after isDone is already set_."
That is, it occurs after `isDone == true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
