dcapwell commented on code in PR #203:
URL: https://github.com/apache/cassandra-accord/pull/203#discussion_r2141141622
##########
accord-core/src/main/java/accord/coordinate/CoordinatePreAccept.java:
##########
@@ -142,7 +142,7 @@ void onNewEpochTopologyMismatch(TopologyMismatch mismatch)
proposeInvalidate(node, node.uniqueTimestamp(Ballot::fromValues),
txnId, route.homeKey(), (outcome, failure) -> {
if (failure != null)
mismatch.addSuppressed(failure);
- setFailure(mismatch);
+ callback.accept(null, mismatch);
Review Comment:
> It is a callback from another process that occurs after isDone is already
set.
that doesn't answer my question. This change is taking 1 line from
`setFailure` and ignoring the rest of the logic (such as monitoring). If this
change actually matters it implies that it was called *after* `isDone == true`
*or* it isn't desirable to have `isDone = true` here (which feels weird as we
are notifying the callback of a result).
Which is it? If we feel its best to special case can we document the *why*?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
