maedhroz commented on code in PR #4175: URL: https://github.com/apache/cassandra/pull/4175#discussion_r2151044699
########## src/java/org/apache/cassandra/service/accord/txn/TxnCondition.java: ########## @@ -460,6 +512,11 @@ public Value(TxnReference reference, Kind kind, ByteBuffer value, ProtocolVersio this.version = version; } + public static EnumSet<Kind> supported() + { + return EnumSet.copyOf(KINDS); Review Comment: nit: I guess either mark this `@VisibleForTesting` or just use `Sets.immutableEnumSet()` for the field? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org