dcapwell commented on code in PR #4175:
URL: https://github.com/apache/cassandra/pull/4175#discussion_r2100702935
##########
src/java/org/apache/cassandra/cql3/terms/Lists.java:
##########
@@ -300,7 +300,7 @@ public Setter(ColumnMetadata column, Term t)
@Override
public boolean requiresTimestamp()
{
- return true;
+ return column.type.isMultiCell();
Review Comment:
bug found in fuzz testing, frozen lists were requiring timestamp which made
it hit this block
```
public void add(Operation operation, TableMetadata tableMetadata)
{
if (isForTxn && (operation.requiresRead() ||
operation.requiresTimestamp()))
{
add(operation.column, ReferenceOperation.create(operation,
tableMetadata));
return;
}
```
this is a immutable bb so can avoid converting to a reference (i think it
fails as a reference but forgot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
