maedhroz commented on code in PR #4175:
URL: https://github.com/apache/cassandra/pull/4175#discussion_r2150525220
##########
src/java/org/apache/cassandra/service/accord/txn/TxnReference.java:
##########
@@ -43,18 +52,22 @@
import org.apache.cassandra.service.accord.serializers.TableMetadatas;
import org.apache.cassandra.service.accord.serializers.Version;
import org.apache.cassandra.utils.ByteBufferUtil;
+import org.apache.cassandra.utils.ObjectSizes;
import static org.apache.cassandra.db.marshal.CollectionType.Kind.SET;
import static
org.apache.cassandra.service.accord.AccordSerializers.columnMetadataSerializer;
public class TxnReference
{
private final int tuple;
+ @Nullable
private final TableMetadata table;
+ @Nullable
private final ColumnMetadata column;
+ @Nullable
Review Comment:
I guess these are all technically nullable (for tests or w/ CAS requests?),
but annotating them as such creates some noise for static analysis tools on
this class. I wonder how hard it would be to make `TxnReference` and interface
and separate the behavior of the normal case from the CAS case....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
