dcapwell commented on code in PR #4257:
URL: https://github.com/apache/cassandra/pull/4257#discussion_r2211275356
##########
src/java/org/apache/cassandra/index/accord/RouteIndexFormat.java:
##########
@@ -284,7 +286,9 @@ static List<Segment> readSegments(Map<IndexComponent,
FileHandle> index) throws
}
byte[] minTerm =
ByteArrayUtil.readWithVIntLength(segmentReader);
byte[] maxTerm =
ByteArrayUtil.readWithVIntLength(segmentReader);
- Segment.Metadata existing = groups.put(group, new
Segment.Metadata(metas, minTerm, maxTerm));
+ Timestamp minTimestamp =
CommandSerializers.timestamp.deserialize(segmentReader);
+ Timestamp maxTimestamp =
CommandSerializers.timestamp.deserialize(segmentReader);
+ Segment.Metadata existing = groups.put(group, new
Segment.Metadata(metas, minTerm, maxTerm, minTimestamp, maxTimestamp));
Review Comment:
i "feel" like there isn't a good memory gain by trying to dedup these
objects, as I don't "feel" like its very likely that the segments will have
identical timestamps and are far more likely to have distinct timestamps...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
