belliottsmith commented on code in PR #4257:
URL: https://github.com/apache/cassandra/pull/4257#discussion_r2218620732
##########
src/java/org/apache/cassandra/index/accord/MemtableIndex.java:
##########
@@ -63,13 +65,23 @@ public Segment write(IndexDescriptor id) throws IOException
return memoryIndex.write(id);
}
- public Collection<ByteBuffer> search(int storeId, TableId tableId, byte[]
start, boolean startInclusive, byte[] end, boolean endInclusive)
+ public void search(int storeId, TableId tableId, byte[] start, byte[] end,
+ Timestamp minTimestamp,
Review Comment:
I think would be clearer to at least name the parameters minTxnId and
maxTxnId, even if we accept Timestamp (realise max may be a Timestamp). Would
be good to apply this more generally, and also to use TxnId where appropriate
(e.g. inside the actual indexes where we only manage TxnId - only the
parameters may be Timestamp instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
