dcapwell commented on code in PR #4257: URL: https://github.com/apache/cassandra/pull/4257#discussion_r2211277310
########## src/java/org/apache/cassandra/index/accord/RouteJournalIndex.java: ########## @@ -414,19 +412,49 @@ else if (e.column() == AccordJournalTable.SyntheticColumn.store_id.metadata && e { storeId = Int32Type.instance.compose(e.getIndexValue()); } + else if (e.column() == AccordJournalTable.SyntheticColumn.txn_id.metadata) Review Comment: i could reject exclusive as the logic is 100% inclusive... this is all synthetic anyways so can only be called with w/e the route index writes and can't come from a user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org