ifesdjeen commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2228799389
##########
accord-core/src/main/java/accord/local/RedundantBefore.java:
##########
@@ -924,6 +936,22 @@ public boolean isShardOnlyApplied(TxnId txnId,
Unseekables<?> participants)
return foldl(participants, Bounds::isShardOnlyApplied, false, txnId);
}
+ public boolean isUnsafeBefore(TxnId txnId, Unseekables<?> participants)
+ {
+ // Definitely safe
+ if (maxUnsafeBefore == TxnId.NONE)
+ return false;
+
+ // TODO: Problem is that, logically, we do know that transactions
after maxUnsafeBefore (txnId.compareTo(maxUnsafeBefore) > 0)
Review Comment:
It was, yes, since I was hunting down a couple more burn test bugs
```
// Maybe unsafe
if (participants == null)
return txnId.compareTo(maxLocallyIncomplete) > 0;
```
should be correct now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
