belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218799328
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -1432,12 +1434,20 @@ enum Validated { INSUFFICIENT, UPDATE_TXN_IGNORE_DEPS,
UPDATE_TXN_KEEP_DEPS, UPD
private static Validated validate(@Nullable Ballot ballot, SaveStatus
newStatus, Command cur, StoreParticipants participants,
Route<?> addRoute, @Nullable Txn
addPartialTxn, @Nullable Deps partialDeps)
{
- return validate(ballot, newStatus, cur, participants, addRoute,
addPartialTxn, partialDeps, null, null);
+ return validate(ballot, newStatus, cur, participants, addRoute,
addPartialTxn, partialDeps, null, null, null);
}
private static Validated validate(@Nullable Ballot ballot, SaveStatus
newStatus, Command cur, StoreParticipants participants,
Route<?> addRoute, @Nullable Txn
addPartialTxn, @Nullable Deps partialDeps,
@Nullable Commit.Kind commitKind,
@Nullable Timestamp executeAt)
+ {
+ return validate(ballot, newStatus, cur, participants, addRoute,
addPartialTxn, partialDeps, commitKind, executeAt, null);
+ }
+
+ private static Validated validate(@Nullable Ballot ballot, SaveStatus
newStatus, Command cur, StoreParticipants participants,
Review Comment:
this isn't wired up, so not sure how I feel about the tracing at present,
need to understand how it can/will be used...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
