belliottsmith commented on code in PR #213:
URL: https://github.com/apache/cassandra-accord/pull/213#discussion_r2218802496
##########
accord-core/src/main/java/accord/local/CommandStores.java:
##########
@@ -699,6 +700,18 @@ protected boolean shouldBootstrap(Node node, Topology
local, Topology newLocalTo
return newLocalTopology.epoch() != 1;
}
+ public AsyncChain<Void> rebootstrap(Node node)
Review Comment:
I think we need to test partial rebootstrap to have confidence in the logic.
I think it would help to also design this as something that can be invoked on a
node that is already up, rather than only as an operation that may be invoked
on restart operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
