michaelsembwever commented on code in PR #4226:
URL: https://github.com/apache/cassandra/pull/4226#discussion_r2237160477
##########
conf/cassandra-env.sh:
##########
@@ -131,9 +131,11 @@ fi
if [ "x$MAX_HEAP_SIZE" = "x" ] && [ "x$HEAP_NEWSIZE" = "x" -o $USING_G1 -eq 0
]; then
MAX_HEAP_SIZE="$CALCULATED_MAX_HEAP_SIZE"
HEAP_NEWSIZE="$CALCULATED_CMS_HEAP_NEWSIZE"
-elif [ "x$MAX_HEAP_SIZE" = "x" ] || [ "x$HEAP_NEWSIZE" = "x" -a $USING_G1 -ne
0 ]; then
- echo "please set or unset MAX_HEAP_SIZE and HEAP_NEWSIZE in pairs when
using CMS GC (see cassandra-env.sh)"
- exit 1
+elif [ $USING_CMS -eq 0 ]; then
Review Comment:
if cms, then `MAX_HEAP_SIZE` and `HEAP_NEWSIZE` must both be set or both be
not set.
if not cms (g1/zcs/shenendoah), then `HEAP_NEWSIZE` must never be set. (we
have to make sure that -XX:G1NewSizePercent=XX is always then set)
but: if nodetool isn't calling cassandra-env.sh anymore, then why patch
cassandra-env.sh at all (especially in 5.0 branch)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
